Re: [PATCH v4] add-patch: response to unknown command

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2024, 16:09 UTC
Message-ID: <xmqqttjkxiai.fsf@gitster.g>
In-Reply-To: <33bb69ad-ec79-4863-97b7-51605b94c9c5@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> There is also a practical argument against using "git diff" to
> generate the expected output as it only works if the diff contains a
> single hunk. If the diff contains more than one hunk "add -p" displays
> them separately.

True, but spliting the output from "git diff" at @@ hunk boundary lines would allow you to hardcode the assumption that "add -p" shows each hunk exactly as "git diff" would. So if we really wanted to have the convenience that the tests' expectation automatically follow what "git diff" of the day happens to produce, it is still a viable approach to use "git diff" output with some post-processing.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.