Re: [PATCH v5 1/2] add-patch: do not show UI messages on stderr

From: Junio C Hamano <gitster@pobox.com>
Date: May 1, 2024, 16:14 UTC
Message-ID: <xmqq5xvx5x1u.fsf@gitster.g>
In-Reply-To: <7a3fcf9c-a70f-47e8-9624-40b407f90242@gmail.com>

phillip.wood123@gmail.com writes:

Show 17 quoted lines

>>>> -		fprintf(stderr, _("No changes.\n"));
>>>> +		err(&s, _("No changes."));
>>>>    	else if (binary_count == s.file_diff_nr)
>>>> -		fprintf(stderr, _("Only binary files changed.\n"));
>>>> +		err(&s, _("Only binary files changed."));
>>>
>>> These two mean we'll now color these messages which we didn't do before. I
> ...
> I think so
> ...
>> -		err(&s, _("Only binary files changed."));
>> +		error(_("only binary files changed"));
>>     	add_p_state_clear(&s);
>>   	return 0;
>> Or, simply leave them untouched in this series.
>
> Either option sounds good to me

We are returning "success" to the caller, so using error() here is a bit strong. Judging from how other messages emitted with err() in this program is meant to help the end user, they are all to tell the user why their input caused no actual change, and showing these two messages the same way as these other messages would be the best for consistency.

So I'm inclined to say that what was posted is good. If it paints these two messages in the same color as others, that is even getter.