Re: [PATCH v3 2/2] history: sign rewritten commits

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2026, 15:00 UTC
Message-ID: <xmqqtsn9o1yj.fsf@gitster.g>
In-Reply-To: <aroX94CD_kOyLnuW@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 17 quoted lines

> On Sun, Sep 13, 2026 at 01:00:45AM +0900, Souma wrote:
>> Add --gpg-sign/--no-gpg-sign support to git history and honor
>> commit.gpgSign when creating replacement commits. Thread the selected
>> signing key through direct rewrites and replayed descendants while
>> preserving the original author identity.
>> 
>> Cover configuration, command-line precedence, explicit keys, split commits,
>> and replayed descendants with GPG-gated tests.
>
> This is much shorter now, which is good. One question to ask yourself
> though is whether there's any subtleties in the changes you perform that
> might want to be explained.
>
> One such subtlety for example is that you reorder the calls to
> `repo_config()`. It's obvious to me, but it may not be obvious to every
> reviewer why you do that. Pointing out and explaining details like this
> in a sentence or two is useful context.

Thanks for pointing this out. It encouraged me to take a peek into the area in the patch ;-).

> Other than these nits about the commit message I'm happy with this
> series as-is. I won't insist on a reroll, but wouldn't mind if you did.
> Thanks!

Thanks for writing, and thanks for reviewing.