Re: [PATCH v3 2/2] history: sign rewritten commits

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2026, 18:52 UTC
Message-ID: <xmqq8q4lmco7.fsf@gitster.g>
In-Reply-To: <xmqqtsn9o1yj.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 17 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>
>> On Sun, Sep 13, 2026 at 01:00:45AM +0900, Souma wrote:
> 
>> One such subtlety for example is that you reorder the calls to
>> `repo_config()`. It's obvious to me, but it may not be obvious to every
>> reviewer why you do that. Pointing out and explaining details like this
>> in a sentence or two is useful context.
>
> Thanks for pointing this out.  It encouraged me to take a peek into
> the area in the patch ;-).
>
>> Other than these nits about the commit message I'm happy with this
>> series as-is. I won't insist on a reroll, but wouldn't mind if you did.
>> Thanks!
>
> Thanks for writing, and thanks for reviewing.

While we are on the topic of the proposed commit log message, is Souma a real name or a handle? Documentation/SubmittingPatches:[[dco]] describes a procedure with legal ramifications, and that is where Documentation/SubmittingPatches:[[real-name]] comes into the picture, so I have to ask.

Thanks.