Re: [PATCH v3 1/2] replay: allow callers to sign commits

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 28, 2026, 07:40 UTC
Message-ID: <aroaBm1G2OjO2TiB@pks.im>
In-Reply-To: <20260912160045.36064-2-git@5ouma.me>

On Sun, Sep 13, 2026 at 01:00:44AM +0900, Souma wrote:

> Add a signing-key option to replay_revisions_options and pass it to
> commit_tree_extended() when creating replayed commits.

This is mostly sufficient. One bit of information that could be useful to the reviewer is that the infra is not used anywhere yet. But that does not warrant a reroll, as the patch looks good to me otherwise.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.