git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/5] Disable "git status" comment prefix

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 5, 2013, 23:09 UTC
Message-ID
<xmqqsixig91j.fsf@gitster.dls.corp.google.com>
In-Reply-To
<vpqioyfukkw.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 13 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
>
>> One caveat, though.  The name "oldStyle" will become problematic,
>> when we want to remove some wart in the output format long after
>> this "no comment prefix by default" series lands.  Some people may
>> expect setting oldStyle=true would give output from 1.8.4 era, while
>> some others would expect that it would give output from 1.8.5 era
>> that does not have comment prefix but still has that wart we will
>> remove down the line.
>
> I'm fine with any name actually (since it is enabled by default, people
> don't need to know the name to benefit from the new output). Maybe
> status.displayCommentPrefix was the best name after all.

Yeah, I think so. It makes it clear what kind of old behaviour the user is asking for.

Previous: Matthieu MoyNext: Jeff King
Message 10 of 17 in “Disable "git status" comment prefix”
  1. 0/5 Disable "git status" comment prefixMatthieu Moy, Sep 5, 2013
  2. 1/5 builtin/stripspace.c: fix broken indentationMatthieu Moy, Sep 5, 2013
  3. 2/5 wt-status: use argv_array APIMatthieu Moy, Sep 5, 2013
  4. 3/5 submodule summary: ignore --for-status optionMatthieu Moy, Sep 5, 2013
  5. 4/5 status: disable display of '#' comment prefix by defaultMatthieu Moy, Sep 5, 2013
  6. 5/5 tests: don't set status.oldStyle file-wideMatthieu Moy, Sep 5, 2013
  7. Matthieu MoySep 5, 2013
  8. Junio C HamanoSep 5, 2013
  9. Matthieu MoySep 5, 2013
  10. Junio C HamanoSep 5, 2013
  11. Jeff KingSep 5, 2013
  12. Matthieu MoySep 6, 2013
  13. Jonathan NiederSep 6, 2013
  14. Matthieu MoySep 6, 2013
  15. Junio C HamanoSep 6, 2013
  16. Matthieu MoySep 6, 2013
  17. Jeff KingSep 6, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.