Re: [PATCH v4 0/5] Disable "git status" comment prefix
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 5, 2013, 23:09 UTC
- Message-ID
- <xmqqsixig91j.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <vpqioyfukkw.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
Show 13 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > >> One caveat, though. The name "oldStyle" will become problematic, >> when we want to remove some wart in the output format long after >> this "no comment prefix by default" series lands. Some people may >> expect setting oldStyle=true would give output from 1.8.4 era, while >> some others would expect that it would give output from 1.8.5 era >> that does not have comment prefix but still has that wart we will >> remove down the line. > > I'm fine with any name actually (since it is enabled by default, people > don't need to know the name to benefit from the new output). Maybe > status.displayCommentPrefix was the best name after all.
Yeah, I think so. It makes it clear what kind of old behaviour the user is asking for.