Re: [PATCH v4 0/5] Disable "git status" comment prefix

From: Jeff King <peff@peff.net>
Date: Sep 6, 2013, 21:55 UTC
Message-ID: <20130906215509.GA13319@sigill.intra.peff.net>
In-Reply-To: <vpq38phsvuc.fsf@anie.imag.fr>

On Fri, Sep 06, 2013 at 07:28:43PM +0200, Matthieu Moy wrote:

Show 11 quoted lines

> >> FWIW, I had the same thought as Junio. I much prefer something like
> >> status.displayCommentPrefix for clarity and future-proofing.
> >
> > Sounds fine, but I don't understand why we'd want this to be an option
> > with a future in the first place.  Why not just fix the remaining bugs
> > before merging to master and make it unconditional?
> 
> I think some old-time users may appreciate to have a
> backward-compatibility option. It doesn't cost much for us, as we need
> the variable internally (to use the prefix in COMMIT_EDITMSG, and not on
> stdout), and it actually makes it easier to test.

Exactly. I kind of prefer the old output, though it is probably just having my brain rotted from seeing it so much. I'm going to give the new behavior a try for a while to see if I adjust, but ultimately I'd like to have the escape hatch. And as you say, it doesn't cost much, since we have to keep both code paths anyway.

Show 6 quoted lines

> I won't change the header part in this topic (no time, sorry), but the
> missing newline before "nothing added" actually sounds like a bug, as
> there is normally a newline after each list of file in `git status`,
> except untracked and ignored.
> 
> I'll fix it as a separate patch in the next round.

Thanks for looking into it.

-Peff