Re: [PATCH v3 4/6] worktree: new config file hierarchy

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2016, 18:45 UTC
Message-ID: <xmqqsi1hilug.fsf@junio.mtv.corp.google.com>
In-Reply-To: <CACsJy8C3wXL-nE1TfS7V8BFNwaQTjMtkQibCswycpX_teaATpQ@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 10 quoted lines

>> I cannot see why it cannot live in $C/common/config, which would be
>> read as the fourth alternative in your earlier enumeration.  What I
>> am missing?
>
> I wasn't clear. The last paragraph is about already released git
> binaries, which does not care about $C/common/config. Suppose you add
> a new worktree with new git binary, which will move common stuff out
> of .git/config to common/config, on a shared repo. If the old binary
> reads that repo, it does not see common config, but it does not know
> where common config is either.

Ah, OK.

Would it make it simpler to invent a specific value for 'xxx' that denotes the main worktree (hence $C/worktrees/xxx/config will always be read by worktrees including the primary one), not to add $C/common/ anything, and use $C/config as the common one instead?

Then the repository format version can live in $C/config that would be noticed by existing versions of Git.