Re: [PATCH v3 1/6] worktree: new repo extension to manage worktree behaviors
- From
Max Kirillov <max@max630.net>
- Date
- Jan 30, 2016, 13:59 UTC
- Message-ID
- <20160130135944.GA4978@wheezy.local>
- In-Reply-To
- <1453808685-21235-2-git-send-email-pclouds@gmail.com>
On Tue, Jan 26, 2016 at 06:44:40PM +0700, Nguyễn Thái Ngọc Duy wrote:
Show 12 quoted lines
> +WORKTREE VERSIONS AND MIGRATION > +------------------------------- > +Multiple worktree is still an experimental feature and evolving. Every > +time the behavior is changed, the "worktree version" is stepped > +up. Worktree version is stored as a configuration variable > +extensions.worktree. > + > +Version 0 > +~~~~~~~~~ > +This is the first release. Version 0 is implied if extensions.worktree > +does not exist. > +
...
Show 5 quoted lines
> +`worktree` > +~~~~~~~~~~ > + > +Define behavior in multiple worktree setup. The value specifies the > +version. Default version is zero.
This sounds too pessimistic. There is now a need to introduce incompatible change, because there is no way to make config separation. There would be a need to increase the version regularly in case of previous option which suggested to hardcode per-worktree versions, so that each change of their list would need a version increase. Now there is no need to increase the version beyond 1, so it can be "version 0 is like in older gits, version 1 is separated config file, and version 2 will never happen" :) The extension parameter coould even be called like "worktreeConfig" and be boolean.