[PATCH 1/5] dir.c: clean the entire struct in clear_exclude_list()
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- Dec 2, 2015, 19:13 UTC
- Message-ID
- <1449083626-20075-2-git-send-email-pclouds@gmail.com>
- In-Reply-To
- <1449083626-20075-1-git-send-email-pclouds@gmail.com>
Make sure "el" can be reuseable again. The problem was el->alloc is not cleared and may cause segfaults next time because add_exclude() thinks el->excludes (being NULL) has enough space. Just clear the entire struct to be safe.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- dir.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dir.c b/dir.c index d2a8f06..b8b4576 100644 --- a/dir.c +++ b/dir.c @@ -564,9 +564,7 @@ void clear_exclude_list(struct exclude_list *el) free(el->excludes); free(el->filebuf); - el->nr = 0; - el->excludes = NULL; - el->filebuf = NULL; + memset(el, 0, sizeof(*el)); } static void trim_trailing_spaces(char *buf)
-- 2.2.0.513.g477eb31