Re: [GSOC] Microproject "Move ~/.git-credential-cache to ~/.config/git"

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 14, 2016, 15:42 UTC
Message-ID: <xmqqshztawwd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAKqreux4aYhXTE9kUHKoKCJ2-4KDWyi58ioCm-CWqXhUYCtEEw@mail.gmail.com>

惠轶群 <huiyiqun@gmail.com> writes:

Show 5 quoted lines

> I'm still confused about following:
>
> 1. should `~/.git-credential-cache` been moved to
> `~/.cache/git/credential`(as the descreption of the micropject says)
> or `~/.config/git/credential`(as the title of the microproject says)?

The latter, I'd think, as you noticed in 2. the former does not make much sense.

> 2. If `~/.cache/git/credential` is the desired target, there seems
> nothing to do with `XDG_CONFIG_HOME`.

Yes, I think the intent of the problem specification is "if it is found in the XDG_CONFIG_HOME use $XDG_CONFIG_HOME/.config/git/* a the location to place it; by the way if the user does not have anything to explicitly say she wants to use a specific location for XDG_CONFIG_HOME, it defaults to "~/.config, hence the Git specific location becomes ~/.config/git/*".

> 3. Does "without breaking compatibility with the old behavior." mean
> that I should still try to connect to the unix socket placed at the
> old place? If yes, which order is prefered?

Let me be vague and oblique on purpose ;-)

We used to have only ~/.gitconfig as the per-user location, and at some point in the history we added XDG_CONFIG_HOME support. Study how that was done (hint: "git log" and "git blame" may be useful tools for this purpose), and imitate it.