Re: [PATCH/RFC/GSoC 2/3] git-credential-cache: put socket to xdg-compatible path

From: 惠轶群 <huiyiqun@gmail.com>
Date: Mar 17, 2016, 10:26 UTC
Message-ID: <CAKqreuyOpNOGmWCwLnKY7_ax7szfsFX8R8gpYRym9BYe+3zdDA@mail.gmail.com>
In-Reply-To: <1458122865-29447-2-git-send-email-huiyiqun@gmail.com>

2016-03-16 18:07 GMT+08:00 Hui Yiqun <huiyiqun@gmail.com>:

Show 23 quoted lines

> move .git-credential-cache/socket to xdg_runtime_dir("credential-cache.sock")
>
> Signed-off-by: Hui Yiqun <huiyiqun@gmail.com>
> ---
>  credential-cache.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/credential-cache.c b/credential-cache.c
> index f4afdc6..40d838b 100644
> --- a/credential-cache.c
> +++ b/credential-cache.c
> @@ -105,7 +105,7 @@ int main(int argc, const char **argv)
>         op = argv[0];
>
>         if (!socket_path)
> -               socket_path = expand_user_path("~/.git-credential-cache/socket");
> +               socket_path = xdg_runtime_dir("credential-cache.sock");
>         if (!socket_path)
>                 die("unable to find a suitable socket path; use --socket");
>
> --
> 2.7.2
>

I'm sure but if user set up git-credential-cache with following command:

    git config --global credential.helper "cache --socket
~/.git-credential-cache/socket"

will the ~ be expanded?