Re: [PATCH/RFC/GSoC 3/3] t0301: test credential-cache support of XDG_RUNTIME_DIR

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2016, 08:12 UTC
Message-ID: <xmqqmvpx1q25.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <729c6af810e3000e789f4afd537b77a8@riseup.net>

谭俊浩 <pickfire@riseup.net> writes:

Show 12 quoted lines

> On 17/03/2016 01:24, Junio C Hamano wrote:
>
>> Using ~/.git-credential-cache/credential-cache.sock would not help
>> at all for existing users, but ~/.git-credential-cache/socket would
>> interoperate well with users with existing versions of Git, no?
>>
>>>> Just being curious, and wanting to see the reasoning behind the
>>>> design decision the patch series makes in the log message of one of
>>>> these patches.
>
> I guess it is better to use /tmp or such instead of $HOME/.* so that
> the users home directory won't be flooded by sockets.

The "fallback" being discussed is to see if $XDG can be used (and use it if so), otherwise see if ~/.git-credential-cache/socket can be used (and use it if so), otherwise die with a message (see credential-cache.c). The order of the falling back may want to be the other way around, but in either case, the definition of "can be used" includes "is there already a directory in which we can create a socket?".

The existing versions have used ~/.git-credential-cache/socket as the default socket path, so it is reasonable to expect that users that are already using the feature already have the directory there.

So I do not think there is any "flooded" involved; if the directory is already there, we can use it to create and use a single socket. It's not like we'd be creating many random new directories in ~/.