Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2016, 17:21 UTC
Message-ID: <xmqqshuvvvxb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160727083406.10241-1-judge.packham@gmail.com>

Chris Packham <judge.packham@gmail.com> writes:

Show 8 quoted lines

> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> Hi,
>
> I noticed --recurse-submodules was missing from the bash completion. This adds
> it. I went for '--recurse-submodules' instead of '--recursive' as I seem to
> recall the former being agreed upon as the better (or least ambiguous) of the
> two terms.

Yup, that position is consistent with what 3446a54c (clone: fixup recurse_submodules option, 2011-02-11) gave us.

Perhaps we should think about deprecating "--recursive"?  I dunno.

Show 15 quoted lines

>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 37888f4..7c06455 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1136,6 +1136,7 @@ _git_clone ()
>  			--depth
>  			--single-branch
>  			--branch
> +			--recurse-submodules
>  			"
>  		return
>  		;;