git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'

From
Stefan Beller <sbeller@google.com>
Date
Jul 29, 2016, 01:26 UTC
Message-ID
<CAGZ79kbCTQx_FAeGkJRRyDotAsdJT6J+4Ab9BHW-YFw6rOqaqQ@mail.gmail.com>
In-Reply-To
<xmqqshutspfc.fsf@gitster.mtv.corp.google.com>
On Thu, Jul 28, 2016 at 9:22 AM, Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>>> Anyway, I'll apply the "addition to the completion" patch.
>>>
>>> Thanks.
>>
>> Thanks for this patch!
>>
>> Note: if we ever decide to resurrect sb/submodule-default-path,
>> we run into a merge conflict. The reasoning for using
>> "--recurse-submodules" instead of a plain "--recurse" makes sense
>> as well, so that merge conflict will be resolved in favor of this patch.
>
> Thanks for an advance warning.  My rerere database has already been
> taught about this conflict ;-)
>
> As to sb/submodule-default-path topic, which has been blocked on
> still-in-flux attribute work, I am tempted to declare that the
> attribute work is not yet thread-ready but it is in a good enough
> shape to base other works on, and have them advance to 'next'.

I am tempted to ask for delaying sb/submodule-default-path a bit more and see if there is an alternative solution.

Inspired by Duys series on submodules and worktree I found a new way how to do the submodule management (separation of the submodule URL as a flag indicating the existence and the actual URL), and that will be very similar to what is implemented in sb/submodule-default-path just even more streamlined. (That said the state of that new series is still vapor and not yet solid, so ... it's hopes and dreams.)

Show 8 quoted lines
>
> The traditional pattern of allowing the callers to randomly allocate
> an array of "struct git_attr_check" and passing the pointer to its
> first element to git_check_attr() function was impossible to extend
> without having to update the callers, but we have migrated away from
> the pattern and the attribute subsystem can be enhanced without
> impacting the callers too much.
>
Previous: Junio C Hamano
Message 6 of 6 in “[PATCHv1] completion: add option '--recurse-submodules' to 'git clone'”
  1. Chris PackhamJul 27, 2016
  2. Junio C HamanoJul 27, 2016
  3. Junio C HamanoJul 27, 2016
  4. Stefan BellerJul 27, 2016
  5. Junio C HamanoJul 28, 2016
  6. Stefan BellerJul 29, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.