Re: [PATCHv1] completion: add option '--recurse-submodules' to 'git clone'
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 27, 2016, 17:32 UTC
- Message-ID
- <xmqqoa5jvven.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqshuvvvxb.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
>> I noticed --recurse-submodules was missing from the bash completion. This adds >> it. I went for '--recurse-submodules' instead of '--recursive' as I seem to >> recall the former being agreed upon as the better (or least ambiguous) of the >> two terms. > > Yup, that position is consistent with what 3446a54c (clone: fixup > recurse_submodules option, 2011-02-11) gave us.
Silly me. The blame actually goes down to ccdd3da6 (clone: Add the --recurse-submodules option as alias for --recursive, 2010-11-04), but the conclusion is the same.
> Perhaps we should think about deprecating "--recursive"? I dunno.
Anyway, I'll apply the "addition to the completion" patch.
Thanks.