Re: [PATCH 0/2] tree-walk improvements

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 26, 2016, 19:43 UTC
Message-ID: <xmqqshsmqwfr.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1474918365-10937-1-git-send-email-novalis@novalis.org>

David Turner <novalis@novalis.org> writes:

Show 7 quoted lines

> The first patch is a re-roll of Peff's patch from 2014 -- here's
> the archive message:
>
> http://git.661346.n2.nabble.com/PATCH-tree-walk-be-more-specific-about-corrupt-tree-errors-td7603558.html
>
> Not sure why this wasn't applied then, but I thought it looked pretty
> good, so I added a few tests.

Thanks. Adding tests is very much appreciated. I however wonder why you needed to reword a perfectly readable "truncated" to something else, though?

Show 5 quoted lines

> Email address note 1: my employer wants me to use my company address,
> but not my company computer, for patches I write on work time.  This
> means that I'm going to continue corresponding from
> novalis@novalis.org, but will send patches with the @twosigma.com
> address in the author line.

That seems like not an uncommon practice ;-)

> Email address note 2: I'm not subscribed to the mailing list these
> days, so please CC me (at novalis@novalis.org) on replies.

It is good to tell others this, but I suspect that it is known by those who are likely to respond to these messages that always CC'ing to individual is the norm on this list ;-)

Thanks.