Re: [PATCH 1/2] tree-walk: be more specific about corrupt tree errors
- From
David Turner <novalis@novalis.org>
- Date
- Sep 27, 2016, 15:21 UTC
- Message-ID
- <1474989716.26902.9.camel@frank>
- In-Reply-To
- <20160927051453.yuvrnao5ldjpzhcj@sigill.intra.peff.net>
On Tue, 2016-09-27 at 01:14 -0400, Jeff King wrote:
Show 9 quoted lines
> I also wonder if $bin_sha1 should actually be more like: > > hex_sha1=$(echo foo | git hash-object --stdin -w) > bin_sha1=$(echo $hex_sha1 | perl -ne 'printf "\\%3o", ord for /./g') > > so that it's a real sha1 (or maybe it is in your original, from an > object that happens to be in the repo; it's hard to tell). I wouldn't > expect the code to actually get to the point of looking at the sha1, but > it's perhaps a more realistic test.
I'm going to do this for this patch, but for the second patch, I don't think it matters, and it's a bit simpler to avoid it. I guess it's probably better to test both ways anyway.