Re: Fwd: New Defects reported by Coverity Scan for git

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 20, 2016, 17:50 UTC
Message-ID: <xmqqshrqhpua.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kabVPhp0_z-e_4jJOFq+jzSE2SsgmFuY-2RUgrEviGKyA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 6 quoted lines

> Not sure what triggered the new finding of coverity as seen below as the
> parse_commit() was not touched. Junios series regarding the merge base
> optimization touches a bit of code nearby though.
>
> Do we want to replace the unchecked places of parse_commit with
> parse_commit_or_die ?

The reason parse_commit() would fail at this point would be because the repository is corrupt, I do not think it would hurt to do such a change.

I agree that it is curious why it shows up as a "new defect", though.

By the way, do you know who is managing the service on our end (e.g. approving new people to be "defect viewer")? The site seems to think I have the power to manage others' subscription, which I do not think I have (I do not go to the site myself). As it spewed quite a many false positives into my mailbox in the past, I do not pay very close attention to these reports these days, but I still read the e-mailed reports every once in a while.

Thanks.