Fwd: New Defects reported by Coverity Scan for git
- From
Stefan Beller <sbeller@google.com>
- Date
- Oct 20, 2016, 17:05 UTC
- Message-ID
- <CAGZ79kabVPhp0_z-e_4jJOFq+jzSE2SsgmFuY-2RUgrEviGKyA@mail.gmail.com>
- In-Reply-To
- <580893d5a4736_4ed37b53181837@ss1435.mail>
Not sure what triggered the new finding of coverity as seen below as the parse_commit() was not touched. Junios series regarding the merge base optimization touches a bit of code nearby though.
Do we want to replace the unchecked places of parse_commit with parse_commit_or_die ?
Thanks, Stefan _________________________________________________________ *** CID 1374088: Error handling issues (CHECKED_RETURN) /commit.c: 913 in mark_redundant() 907 908 work = xcalloc(cnt, sizeof(*work)); 909 redundant = xcalloc(cnt, 1); 910 ALLOC_ARRAY(filled_index, cnt - 1); 911 912 for (i = 0; i < cnt; i++)
>>> CID 1374088: Error handling issues (CHECKED_RETURN) >>> Calling "parse_commit" without checking return value (as is done elsewhere 37 out of 45 times).
913 parse_commit(array[i]); 914 for (i = 0; i < cnt; i++) { 915 struct commit_list *common; 916 917 if (redundant[i]) 918 continue;