git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Fwd: New Defects reported by Coverity Scan for git

From
Stefan Beller <sbeller@google.com>
Date
Oct 20, 2016, 17:05 UTC
Message-ID
<CAGZ79kabVPhp0_z-e_4jJOFq+jzSE2SsgmFuY-2RUgrEviGKyA@mail.gmail.com>
In-Reply-To
<580893d5a4736_4ed37b53181837@ss1435.mail>

Not sure what triggered the new finding of coverity as seen below as the parse_commit() was not touched. Junios series regarding the merge base optimization touches a bit of code nearby though.

Do we want to replace the unchecked places of parse_commit with parse_commit_or_die ?

Thanks, Stefan _________________________________________________________ *** CID 1374088: Error handling issues (CHECKED_RETURN) /commit.c: 913 in mark_redundant() 907 908 work = xcalloc(cnt, sizeof(*work)); 909 redundant = xcalloc(cnt, 1); 910 ALLOC_ARRAY(filled_index, cnt - 1); 911 912 for (i = 0; i < cnt; i++)

>>>     CID 1374088:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "parse_commit" without checking return value (as is done elsewhere 37 out of 45 times).

913 parse_commit(array[i]); 914 for (i = 0; i < cnt; i++) { 915 struct commit_list *common; 916 917 if (redundant[i]) 918 continue;

Next: Junio C Hamano
Message 1 of 9 in “Fwd: New Defects reported by Coverity Scan for git”
  1. Stefan BellerOct 20, 2016
  2. Junio C HamanoOct 20, 2016
  3. Stefan BellerOct 20, 2016
  4. Junio C HamanoOct 20, 2016
  5. commit parsing: replace unchecked parse_commit by parse_commit_or_dieStefan Beller, Oct 20, 2016
  6. Stefan BellerOct 20, 2016
  7. Jeff KingOct 20, 2016
  8. Junio C HamanoOct 20, 2016
  9. Jeff KingOct 20, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.