git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] rebase --signoff

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 17, 2017, 07:12 UTC
Message-ID
<xmqqshl7ik21.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170415144103.11986-1-giuseppe.bilotta@gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
> Allow signing off a whole patchset by rebasing it with the --signoff
> option, which is simply passed through to git am.
>  Documentation/git-rebase.txt |  5 +++++
>  builtin/am.c                 | 39 +++++++++++++++++--------------------
>  git-rebase.sh                |  3 ++-
>  t/t3428-rebase-signoff.sh    | 46 ++++++++++++++++++++++++++++++++++++++++++++
Two questions.
 - Is it better to add a brand new test script than adding new tests
   to existing scripts that test "git rebase"?
 - How does this interact with "git rebase -i" and other modes of
   operation?
Previous: Junio C HamanoNext: Giuseppe Bilotta
Message 7 of 10 in “rebase --signoff”
  1. 0/3 rebase --signoffGiuseppe Bilotta, Apr 15, 2017
  2. 1/3 builtin/am: obey --signoff also when --rebasingGiuseppe Bilotta, Apr 15, 2017
  3. 2/3 builtin/am: fold am_signoff() into am_append_signoff()Giuseppe Bilotta, Apr 15, 2017
  4. 3/3 rebase: pass --[no-]signoff option to git amGiuseppe Bilotta, Apr 15, 2017
  5. Giuseppe BilottaApr 15, 2017
  6. Junio C HamanoApr 17, 2017
  7. Junio C HamanoApr 17, 2017
  8. Giuseppe BilottaApr 17, 2017
  9. Junio C HamanoApr 18, 2017
  10. Giuseppe BilottaApr 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.