git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] rebase: pass --[no-]signoff option to git am

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 17, 2017, 04:17 UTC
Message-ID
<xmqqa87fk6r4.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAOxFTczZS6aDGzDVLskQGObtDOeLL_i3-8jJdh8OrQFXVGbOHQ@mail.gmail.com>
Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
Show 9 quoted lines
> Damnit! I just realized that I forgot to amend before the format-patch:
>
> On Sat, Apr 15, 2017 at 4:41 PM, Giuseppe Bilotta
> <giuseppe.bilotta@gmail.com> wrote:
>
>> +signoff!           passed to 'git am'
>
> This should be without the ! or --no-signoff is not accepted. Do I
> need to resend or ... ?

Resend or send something that can be "git apply"ed, which would reduce the chance of mistakes. Let the maintainer _TYPE_ as little as possible, or typoes will sneak in.

Thanks.
Previous: Giuseppe BilottaNext: Junio C Hamano
Message 6 of 10 in “rebase --signoff”
  1. 0/3 rebase --signoffGiuseppe Bilotta, Apr 15, 2017
  2. 1/3 builtin/am: obey --signoff also when --rebasingGiuseppe Bilotta, Apr 15, 2017
  3. 2/3 builtin/am: fold am_signoff() into am_append_signoff()Giuseppe Bilotta, Apr 15, 2017
  4. 3/3 rebase: pass --[no-]signoff option to git amGiuseppe Bilotta, Apr 15, 2017
  5. Giuseppe BilottaApr 15, 2017
  6. Junio C HamanoApr 17, 2017
  7. Junio C HamanoApr 17, 2017
  8. Giuseppe BilottaApr 17, 2017
  9. Junio C HamanoApr 18, 2017
  10. Giuseppe BilottaApr 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.