Re: [PATCH 0/3] rebase --signoff

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Apr 18, 2017, 08:40 UTC
Message-ID: <CAOxFTcyv_o8Gbjj-R0g6eK-i1QDZUA9okwq=7Yb4iW3n=kF-mQ@mail.gmail.com>
In-Reply-To: <xmqqinm2inc2.fsf@gitster.mtv.corp.google.com>

On Tue, Apr 18, 2017 at 2:14 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 12 quoted lines

> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>
>>>  - How does this interact with "git rebase -i" and other modes of
>>>    operation?
>>
>> A better question would maybe be how do we want this to interact?
>
> If "git rebase -i/-m --signoff" will not do anything (which I
> suspect is what we have here), we at least would want it to be
> documented, or the combination be made to error out, I would think.
>
> A better question can wait until that happens ;-)

I've been looking into adding signoff support to the rest of git-rebase, but the thing is far less trivial to do than I initially imagined, since the interactive part is split across a number of sections and files, including C helpers and the sequencer itself. It can _probably_ be done, but building tests for all corner cases is quite the daunting task. I think that for the moment I'll resubmit with the Documentation fix to declare it non-interactive only, and then leave the extended for later.

-- 
Giuseppe "Oblomov" Bilotta