Re: [PATCH] http-backend: allow empty CONTENT_LENGTH

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 7, 2018, 09:49 UTC
Message-ID: <xmqqsh2ly6vw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAF7_NFRg8wOQ0JbjkJ2gpxKs+oh3s8qXVSPfsWSth2tiUK39hw@mail.gmail.com>

Max Kirillov <max@max630.net> writes:

> Actually, another reason for the latest issue was that CONTENT_LENGTH
> is parsed for GET requests at all. It should be parsed only for POST
> requests, or, rather, only for upoad-pack and receive-pack requests.

Not really. The layered design of the HTTP protocol means that any request type can have non-empty body, but request types for which no semantics of the body is defined must ignore what is in the body, which in turn means we need to parse and pay attention to the content length etc. to find the end of the body, if only to ignore it.

In any case, hopefully we can fix this before the final, as this is a regression introduced during this cycle?