[PATCH v2] http-backend test: make empty CONTENT_LENGTH test more realistic
- From
Max Kirillov <max@max630.net>
- Date
- Sep 11, 2018, 20:33 UTC
- Message-ID
- <20180911203336.4601-1-max@max630.net>
- In-Reply-To
- <20180911040621.GD20518@aiede.svl.corp.google.com>
This is a test of smart HTTP, so it should use the smart HTTP endpoints (e.g. /info/refs?service=git-receive-pack), not dumb HTTP (HEAD).
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Max Kirillov <max@max630.net> ---
> do you know why the test passes without 574c513e8d (http-backend: allow empty CONTENT_LENGTH, 2018-09-10)?
Because I did not know what is QUERY_STRING (it is the part after "?"). Fixed now (Somehow I did see the failure during development. Maybe there was another parameter before?)
I suspect it is not OK in other places of the test, but I hope it should not affect the result t/t5562-http-backend-content-length.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t5562-http-backend-content-length.sh b/t/t5562-http-backend-content-length.sh index f94d01f69e..b24d8b05a4 100755 --- a/t/t5562-http-backend-content-length.sh +++ b/t/t5562-http-backend-content-length.sh @@ -155,8 +155,8 @@ test_expect_success 'CONTENT_LENGTH overflow ssite_t' ' test_expect_success 'empty CONTENT_LENGTH' ' env \ - QUERY_STRING=/repo.git/HEAD \ - PATH_TRANSLATED="$PWD"/.git/HEAD \ + QUERY_STRING="service=git-receive-pack" \ + PATH_TRANSLATED="$PWD"/.git/info/refs \ GIT_HTTP_EXPORT_ALL=TRUE \ REQUEST_METHOD=GET \ CONTENT_LENGTH="" \
-- 2.17.0.1185.g782057d875