Re: [PATCH] http-backend: allow empty CONTENT_LENGTH

From

Max Kirillov <max@max630.net>

Date

Sep 7, 2018, 03:27 UTC

Message-ID

<20180907032740.GA20545@jessie.local>

In-Reply-To

<xmqq1sa6z3zp.fsf@gitster-ct.c.googlers.com>

On Thu, Sep 06, 2018 at 02:54:18PM -0700, Junio C Hamano wrote:

> Max Kirillov <max@max630.net> writes:
>> This should fix it. I'm not sure should it treat it as 0 or "-1"
>> At least the tests mentioned by Jeff fails if I try to treat missing CONTENT_LENGTH as "-1"
>> So keep the existing behavior as much as possible
> 
> I am not sure what you mean by the above, between 0 and -1.  The
> code signals the caller of get_content_length() that req_len is -1
> which is used as a sign to read through to the EOF, so it appears to
> me that the code treats missing content-length (i.e. str == NULL
> case) as "-1".

-- >8 --

@@ -353,8 +353,12 @@ static ssize_t get_content_length(void)
        ssize_t val = -1;
        const char *str = getenv("CONTENT_LENGTH");
 
-       if (str && *str && !git_parse_ssize_t(str, &val))
-               die("failed to parse CONTENT_LENGTH: %s", str);
+       if (str && *str) {
+               if (!git_parse_ssize_t(str, &val))
+                       die("failed to parse CONTENT_LENGTH: %s", str);
+       } else
+               val = 0;
+
        return val;
 }