Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 21, 2018, 16:32 UTC
- Message-ID
- <xmqqsh22x14v.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180920174722.GH22921@ofb.net>
frederik@ofb.net writes:
Show 18 quoted lines
> On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote: >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote: >> > > @@ -23,7 +26,7 @@ OPTIONS >> > > >> > > --mode=<mode>:: >> > > Specify layout mode. See configuration variable column.ui for option >> > > - syntax. >> > > + syntax (in git-config(1)). >> >> I think we usually link to other commands with "linkgit", like >> linkgit:git-config[1] >> >> Other than that, the rest looks good. > > Thank you, then do I edit the patch and resubmit as PATCH v2 with the > message ID and all that? > > Frederick
If this is the only change in the whole 3 patches, then I can just squash in the following to save one round-trip.
Documentation/git-column.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-column.txt b/Documentation/git-column.txt index 5bbb51068e..763afabb6d 100644 --- a/Documentation/git-column.txt +++ b/Documentation/git-column.txt @@ -26,7 +26,7 @@ OPTIONS --mode=<mode>:: Specify layout mode. See configuration variable column.ui for option - syntax (in git-config(1)). + syntax in linkgit:git-config[1]. --raw-mode=<n>:: Same as --mode but take mode encoded as a number. This is mainly used