git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Sep 21, 2018, 05:32 UTC
Message-ID
<CAPig+cQA5O_Zhe0wKzpppaQji997z2hfevnRMLW2nLRgce-YzQ@mail.gmail.com>
In-Reply-To
<20180920174722.GH22921@ofb.net>
On Thu, Sep 20, 2018 at 1:47 PM <frederik@ofb.net> wrote:
Show 14 quoted lines
> On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:
> > On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:
> > > > @@ -23,7 +26,7 @@ OPTIONS
> > > >
> > > >  --mode=<mode>::
> > > >   Specify layout mode. See configuration variable column.ui for option
> > > > - syntax.
> > > > + syntax (in git-config(1)).
> >
> > I think we usually link to other commands with "linkgit", like
> > linkgit:git-config[1]
>
> Thank you, then do I edit the patch and resubmit as PATCH v2 with the
> message ID and all that?

Editing the patch directly is not recommended. More typical would be to use "git rebase -i" and/or "git commit --amend" to make changes to the commits themselves (that is, rewrite history), taking review comments into account (and generally polishing the changes). Once the edits are complete, re-generate the patches with git-format-patch and re-send the entire series as v2 with git-send-email (or some people skip git-format-patch and go directly to git-send-email to both format and send the patches as one step).

You can use the -v option of git-format-patch to mark the series as v2.

When sending v2 via git-send-email, you can use the --in-reply-to option with the message ID of the v1 cover letter to tie the re-roll to the original. (The message ID of the v1 cover letter is "20180919201231.609-1-frederik@ofb.net".)

Previous: frederik@ofb.netNext: Junio C Hamano
Message 10 of 15 in “some documentation changes from the beginning of the alphabet”
  1. 0/3 some documentation changes from the beginning of the alphabetFrederick Eaton, Sep 19, 2018
  2. 1/3 git-archimport.1: specify what kind of Arch we're talking aboutFrederick Eaton, Sep 19, 2018
  3. Junio C HamanoSep 19, 2018
  4. frederik@ofb.netSep 19, 2018
  5. 3/3 git-describe.1: clarify that "human readable" is also git-readableFrederick Eaton, Sep 19, 2018
  6. 2/3 git-column.1: clarify initial description, provide examplesFrederick Eaton, Sep 19, 2018
  7. Junio C HamanoSep 19, 2018
  8. Duy NguyenSep 20, 2018
  9. frederik@ofb.netSep 20, 2018
  10. Eric SunshineSep 21, 2018
  11. Junio C HamanoSep 21, 2018
  12. frederik@ofb.netSep 21, 2018
  13. Junio C HamanoSep 19, 2018
  14. Eric SunshineSep 21, 2018
  15. frederik@ofb.netSep 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.