git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] git-column.1: clarify initial description, provide examples

From
Ffrederik@ofb.net <frederik@ofb.net>
Date
Sep 21, 2018, 16:48 UTC
Message-ID
<20180921164802.GB11082@ofb.net>
In-Reply-To
<xmqqsh22x14v.fsf@gitster-ct.c.googlers.com>

Thank you Junio, maybe I will have another chance to get practice sending a v2 patch.

On Fri, Sep 21, 2018 at 09:32:00AM -0700, Junio C Hamano wrote:
Show 41 quoted lines
> frederik@ofb.net writes:
> 
> > On Thu, Sep 20, 2018 at 06:23:03PM +0200, Duy Nguyen wrote:
> >> On Wed, Sep 19, 2018 at 03:59:58PM -0700, Junio C Hamano wrote:
> >> > > @@ -23,7 +26,7 @@ OPTIONS
> >> > >  
> >> > >  --mode=<mode>::
> >> > >  	Specify layout mode. See configuration variable column.ui for option
> >> > > -	syntax.
> >> > > +	syntax (in git-config(1)).
> >> 
> >> I think we usually link to other commands with "linkgit", like
> >> linkgit:git-config[1]
> >> 
> >> Other than that, the rest looks good.
> >
> > Thank you, then do I edit the patch and resubmit as PATCH v2 with the
> > message ID and all that?
> >
> > Frederick
> 
> If this is the only change in the whole 3 patches, then I can just
> squash in the following to save one round-trip.
> 
>  Documentation/git-column.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-column.txt b/Documentation/git-column.txt
> index 5bbb51068e..763afabb6d 100644
> --- a/Documentation/git-column.txt
> +++ b/Documentation/git-column.txt
> @@ -26,7 +26,7 @@ OPTIONS
>  
>  --mode=<mode>::
>  	Specify layout mode. See configuration variable column.ui for option
> -	syntax (in git-config(1)).
> +	syntax in linkgit:git-config[1].
>  
>  --raw-mode=<n>::
>  	Same as --mode but take mode encoded as a number. This is mainly used
> 
Previous: Junio C HamanoNext: Junio C Hamano
Message 12 of 15 in “some documentation changes from the beginning of the alphabet”
  1. 0/3 some documentation changes from the beginning of the alphabetFrederick Eaton, Sep 19, 2018
  2. 1/3 git-archimport.1: specify what kind of Arch we're talking aboutFrederick Eaton, Sep 19, 2018
  3. Junio C HamanoSep 19, 2018
  4. frederik@ofb.netSep 19, 2018
  5. 3/3 git-describe.1: clarify that "human readable" is also git-readableFrederick Eaton, Sep 19, 2018
  6. 2/3 git-column.1: clarify initial description, provide examplesFrederick Eaton, Sep 19, 2018
  7. Junio C HamanoSep 19, 2018
  8. Duy NguyenSep 20, 2018
  9. frederik@ofb.netSep 20, 2018
  10. Eric SunshineSep 21, 2018
  11. Junio C HamanoSep 21, 2018
  12. frederik@ofb.netSep 21, 2018
  13. Junio C HamanoSep 19, 2018
  14. Eric SunshineSep 21, 2018
  15. frederik@ofb.netSep 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.