Re: [PATCH v3 3/3] send-email: do defaults -> config -> getopt in that order
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 17, 2019, 03:43 UTC
- Message-ID
- <xmqqsgtd3fw3.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <xmqqh89u3sdw.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Ah, sorry that nobody noticed that case, but you are right. Because > the ident is used as a part of the key to find identity-specific > configuration values, if the command line gives one, we must have an > access to it before we start reading the configuration. In that sense, > it is more fundamental to special-case the option. > > We are past -rc0, so I am inclined to revert the change (and perhaps > replace it with the other "fix" that did not break the parsing order > like these patches did), with an expectation that a clever fix will > be found later, *unless* a simple and correct fix is found quickly.
Oops, spoke too soon. The topic hasn't escaped to 'master' yet, so I'll make sure it stays that way. Thanks for catching a regression before it gets too late.