Re: [PATCH v2 2/2] send-email: honor transferencoding config option again

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 8, 2019, 23:12 UTC
Message-ID: <20190508231228.GC7458@genre.crustytoothpaste.net>
In-Reply-To: <20190508105607.178244-3-gitster@pobox.com>

On Wed, May 08, 2019 at 07:56:07PM +0900, Junio C Hamano wrote:

Show 20 quoted lines

> diff --git a/git-send-email.perl b/git-send-email.perl
> index 98bc295c6e..b9dd775b63 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -231,7 +231,7 @@ sub do_edit {
>  my (@suppress_cc);
>  my ($auto_8bit_encoding);
>  my ($compose_encoding);
> -my $target_xfer_encoding = 'auto';
> +my ($target_xfer_encoding);
>  
>  my ($debug_net_smtp) = 0;		# Net::SMTP, see send_message()
>  
> @@ -271,7 +271,7 @@ sub do_edit {
>      "from" => [\$sender],
>      "assume8bitencoding" => [\$auto_8bit_encoding],
>      "composeencoding" => [\$compose_encoding],
> -    "transferencoding" => [\$target_xfer_encoding],
> +    "transferencoding" => [\$target_xfer_encoding, 'auto'],
>  );

These changes seem sane and the series makes the second one straightforward. It's also a nice way to add defaults in the future, so thanks for that.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204