Re: [PATCH v3 3/3] send-email: do defaults -> config -> getopt in that order

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 9, 2019, 23:51 UTC
Message-ID: <20190509235112.GD7458@genre.crustytoothpaste.net>
In-Reply-To: <20190509114830.29647-4-avarab@gmail.com>

On Thu, May 09, 2019 at 01:48:30PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> @@ -363,6 +371,11 @@ sub read_config {
>  	}
>  }
>  
> +$identity = Git::config(@repo, "sendemail.identity");
> +read_config("sendemail.$identity") if defined $identity;
> +read_config("sendemail");
> +read_config("sendemail");

Did we really want to call this function twice with the same argument? If so, perhaps a comment is appropriate explaining why.

In general, I'm not opposed to this approach, either. It does make it easier to handle parsing in general. However, having said that, I'm fine with either your series or Junio's.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204