Re: [PATCH] revision: remove stray whitespace when name empty

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 10, 2019, 16:29 UTC
Message-ID: <xmqqsgsho145.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190609130004.GB23555@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> Your patch only helps with this at all because you're using the "tree:1"
> ...
> because there you'll have actual names which cat-file will choke on. So
> it seems like this is helping only a very limited use case.
> ...
> Alternatively, it would be reasonable to me to have an option for
> "rev-list --objects" to have an option to suppress the filename (and
> space) entirely.

Yup, I think that is a more reasonable short-term change compared to the patch being discussed, and ...

Show 5 quoted lines

> I think in the longer run along those lines that "--objects" should
> allow cat-file style pretty-print formats, which would eliminate the
> need to pipe to cat-file in the first place. That makes this parsing
> problem go away entirely, and it's way more efficient to boot (rev-list
> already knows the types!).

... of course this makes tons of sense.

Thanks.