Re: [PATCH] revision: remove stray whitespace when name empty

From: Jeff King <peff@peff.net>
Date: Jun 13, 2019, 15:20 UTC
Message-ID: <20190613152028.GA7459@sigill.intra.peff.net>
In-Reply-To: <20190612193745.GB233791@google.com>

On Wed, Jun 12, 2019 at 12:37:45PM -0700, Emily Shaffer wrote:

Show 8 quoted lines

> > > Alternatively, it would be reasonable to me to have an option for
> > > "rev-list --objects" to have an option to suppress the filename (and
> > > space) entirely.
> > 
> > Yup, I think that is a more reasonable short-term change compared to
> > the patch being discussed, and ...
> 
> I like this too. Starting work on it today.

Great!

Show 11 quoted lines

> > > I think in the longer run along those lines that "--objects" should
> > > allow cat-file style pretty-print formats, which would eliminate the
> > > need to pipe to cat-file in the first place. That makes this parsing
> > > problem go away entirely, and it's way more efficient to boot (rev-list
> > > already knows the types!).
> > 
> > ... of course this makes tons of sense.
> 
> Probably not going to start work on this now, but I will make a note to
> myself to have a look if I have some spare time soon, and keep an eye
> out for reviews in that area.

That's fine. I suspect it will be quite involved, because the format placeholders you'd want for "objects" are going to be more like "cat-file" ones than like the existing pretty.c ones. So I think this really implies unifying those format systems, which is a long-term project that Olga has been working on.

-Peff