Re: [PATCH v2] rev-list: teach --oid-only to enable piping

From: Emily Shaffer <emilyshaffer@google.com>
Date: Jun 14, 2019, 23:29 UTC
Message-ID: <20190614232946.GF233791@google.com>
In-Reply-To: <20190614160728.GA30083@sigill.intra.peff.net>

On Fri, Jun 14, 2019 at 12:07:28PM -0400, Jeff King wrote:

> On Thu, Jun 13, 2019 at 02:51:03PM -0700, Emily Shaffer wrote:

Show 11 quoted lines

> > +test_expect_success 'rev-list --objects --oid-only is usable by cat-file' '
> > +	git rev-list --objects --oid-only --all >list-output &&
> > +	git cat-file --batch-check <list-output >cat-output &&
> > +	! grep missing cat-output
> > +'
> 
> Usually we prefer to look for the expected output, rather than making
> sure we did not find the unexpected. But I'm not sure if that might be
> burdensome in this case (i.e., if there's a bunch of cruft coming out of
> "rev-list" that would be annoying to match, and might even change as
> people add more tests). So I'm OK with it either way.

My (newbie) opinion is that in this case, we specifically want to know that cat-file didn't choke on objects which we know exist (since they came from rev-list). I have the feeling that checking for the exact objects returned instead (or a sample of them) would be more brittle and would also make the wording of the test less direct.

So if there's no complaint either way, I'd prefer to leave it the way it is.

By the way, rev-list-misc.sh has a number of other existing "! grep ..." lines.

 - Emily