Re: jk/test-commit-bulk,

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 23, 2019, 15:42 UTC
Message-ID: <xmqqsgqwu59z.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190719215417.GA31841@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

>>  Needs a bit more polishing.
>>  I think I spotted one unused command, which we may want to remove, though.
>
> I think these comments are out-of-date. The unused command was fixed up
> in v2 of the first patch, and then I did a little extra polishing in v3:
>
>   https://public-inbox.org/git/20190702051649.GA16344@sigill.intra.peff.net/

Thanks, indeed. I've been a bit under the weather and my responses may be a bit slow (haven't caught up with my mailbox, either X-<).

Will replace.  Thanks for all the help.

Show 21 quoted lines

>
> Together with your SQUASH fixup, I think that covers all comments. For
> convenience, here's v3 again as a whole series which can replace what
> you have already (including the squash).
>
>   [1/6]: test-lib: introduce test_commit_bulk
>   [2/6]: t5310: increase the number of bitmapped commits
>   [3/6]: t3311: use test_commit_bulk
>   [4/6]: t5702: use test_commit_bulk
>   [5/6]: t5703: use test_commit_bulk
>   [6/6]: t6200: use test_commit_bulk
>
>  t/t3311-notes-merge-fanout.sh      |  10 +--
>  t/t5310-pack-bitmaps.sh            |  15 +---
>  t/t5702-protocol-v2.sh             |  10 +--
>  t/t5703-upload-pack-ref-in-want.sh |   4 +-
>  t/t6200-fmt-merge-msg.sh           |   7 +-
>  t/test-lib-functions.sh            | 123 +++++++++++++++++++++++++++++
>  6 files changed, 136 insertions(+), 33 deletions(-)
>
> -Peff