git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/6] t5310: increase the number of bitmapped commits

From
Jeff King <peff@peff.net>
Date
Jul 19, 2019, 21:56 UTC
Message-ID
<20190719215609.GB32188@sigill.intra.peff.net>
In-Reply-To
<20190719215417.GA31841@sigill.intra.peff.net>

The bitmap index we compute in t5310 has only 20 commits in it. This gives poor coverage of bitmap_writer_select_commits(), which simply writes a bitmap for everything when there are fewer than 100 commits.

Let's bump the number of commits in the test to cover the more complex code paths (this does drop coverage of the individual lines of the trivial path, but the complex path does everything it does and more).

Signed-off-by: Jeff King <peff@peff.net>
---
 t/t5310-pack-bitmaps.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
index 3aab7024ca..6640329ebf 100755
--- a/t/t5310-pack-bitmaps.sh
+++ b/t/t5310-pack-bitmaps.sh
@@ -21,7 +21,7 @@ has_any () {
 }
 
 test_expect_success 'setup repo with moderate-sized history' '
-	test_commit_bulk --id=file 10 &&
+	test_commit_bulk --id=file 100 &&
 	git checkout -b other HEAD~5 &&
 	test_commit_bulk --id=side 10 &&
 	git checkout master &&
-- 
2.22.0.993.gcc1030c86b
Previous: Jeff KingNext: Jeff King
Message 4 of 9 in “What's cooking in git.git (Jul 2019, #05; Fri, 19)”
  1. Junio C HamanoJul 19, 2019
  2. jk/test-commit-bulk, was: What's cooking in git.git (Jul 2019, #05; Fri, 19)Jeff King, Jul 19, 2019
  3. 1/6 test-lib: introduce test_commit_bulkJeff King, Jul 19, 2019
  4. 2/6 t5310: increase the number of bitmapped commitsJeff King, Jul 19, 2019
  5. 3/6 t3311: use test_commit_bulkJeff King, Jul 19, 2019
  6. 4/6 t5702: use test_commit_bulkJeff King, Jul 19, 2019
  7. 5/6 t5703: use test_commit_bulkJeff King, Jul 19, 2019
  8. 6/6 t6200: use test_commit_bulkJeff King, Jul 19, 2019
  9. Junio C HamanoJul 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.