git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 6/6] t6200: use test_commit_bulk

From
Jeff King <peff@peff.net>
Date
Jul 19, 2019, 21:56 UTC
Message-ID
<20190719215623.GF32188@sigill.intra.peff.net>
In-Reply-To
<20190719215417.GA31841@sigill.intra.peff.net>

There's a loop that creates 30 commits using test_commit. Using test_commit_bulk speeds this up from:

  Benchmark #1: ./t6200-fmt-merge-msg.sh --root=/var/ram/git-tests
    Time (mean ± σ):      1.926 s ±  0.240 s    [User: 1.055 s, System: 0.963 s]
    Range (min … max):    1.431 s …  2.166 s    10 runs
to:
  Benchmark #1: ./t6200-fmt-merge-msg.sh --root=/var/ram/git-tests
    Time (mean ± σ):      1.343 s ±  0.179 s    [User: 766.5 ms, System: 662.9 ms]
    Range (min … max):    1.032 s …  1.664 s    10 runs
for an average savings of over 30%.
Signed-off-by: Jeff King <peff@peff.net>
---
 t/t6200-fmt-merge-msg.sh | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/t/t6200-fmt-merge-msg.sh b/t/t6200-fmt-merge-msg.sh
index 93f23cfa82..8a72b4c43a 100755
--- a/t/t6200-fmt-merge-msg.sh
+++ b/t/t6200-fmt-merge-msg.sh
@@ -66,12 +66,7 @@ test_expect_success setup '
 	git commit -a -m "Right #5" &&
 
 	git checkout -b long &&
-	i=0 &&
-	while test $i -lt 30
-	do
-		test_commit $i one &&
-		i=$(($i+1))
-	done &&
+	test_commit_bulk --start=0 --message=%s --filename=one 30 &&
 
 	git show-branch &&
 
-- 
2.22.0.993.gcc1030c86b
Previous: Jeff KingNext: Junio C Hamano
Message 8 of 9 in “What's cooking in git.git (Jul 2019, #05; Fri, 19)”
  1. Junio C HamanoJul 19, 2019
  2. jk/test-commit-bulk, was: What's cooking in git.git (Jul 2019, #05; Fri, 19)Jeff King, Jul 19, 2019
  3. 1/6 test-lib: introduce test_commit_bulkJeff King, Jul 19, 2019
  4. 2/6 t5310: increase the number of bitmapped commitsJeff King, Jul 19, 2019
  5. 3/6 t3311: use test_commit_bulkJeff King, Jul 19, 2019
  6. 4/6 t5702: use test_commit_bulkJeff King, Jul 19, 2019
  7. 5/6 t5703: use test_commit_bulkJeff King, Jul 19, 2019
  8. 6/6 t6200: use test_commit_bulkJeff King, Jul 19, 2019
  9. Junio C HamanoJul 23, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.