Re: [PATCH 2/7] index-pack: remove redundant parameter

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2020, 21:01 UTC
Message-ID: <xmqqsgcb3ghn.fsf@gitster.c.googlers.com>
In-Reply-To: <648ec34821bd435468a0917167bdeef7ca101c02.1598296530.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> find_{ref,ofs}_delta_{,children} take an enum object_type parameter, but
> the object type is already present in the name of the function. Remove
> that parameter from these functions.

Interesting.

These "find children" are the only caller for each delta type and they always pass OFS/REF constant that corresponds to them, so find_*_delta() can lose the type. But compare_*_delta_bases() cannot, as the other one in the objects[] array may be of different type.

Makes sense.  Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.