Re: [PATCH 0/7] Better threaded delta resolution in index-pack (another try)

From: Jonathan Tan <jonathantanmy@google.com>
Date: Aug 25, 2020, 18:11 UTC
Message-ID: <20200825181145.1091378-1-jonathantanmy@google.com>
In-Reply-To: <20200824220829.GA802799@coredump.intra.peff.net>

Show 11 quoted lines

> The overall time seems to get slightly worse, though (HEAD~7 is before
> your patch, HEAD is with it):
> 
>   Test                                           HEAD~7               HEAD                    
>   --------------------------------------------------------------------------------------------
>   5302.9: index-pack default number of threads   71.96(376.11+3.66)   74.18(390.62+6.08) +3.1%
> 
> There may be other cases that get better, though. A 3% increase here is
> probably OK if we get something for it. But if our primary goal here is
> increasing multithread efficiency, then we should be able to show some
> benchmark that improves. :)

Ah...good question. Cloning from https://fuchsia.googlesource.com/third_party/vulkan-cts (mentioned in patch 7), cd-ing to the pack dir, and running:

  git index-pack --stdin -o foo <*.pack

I got 8m2.878s with my patches and 12m6.365s without. But I ran this on a cloud virtual machine (what I have access to right now) so the numbers might look different on a dedicated machine.