From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Aug 2020 21:01:56 GMT
Subject: Re: [PATCH 2/7] index-pack: remove redundant parameter
Message-ID: <xmqqsgcb3ghn.fsf@gitster.c.googlers.com>
In-Reply-To: <648ec34821bd435468a0917167bdeef7ca101c02.1598296530.git.jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> find_{ref,ofs}_delta_{,children} take an enum object_type parameter, but
> the object type is already present in the name of the function. Remove
> that parameter from these functions.

Interesting.  

These "find children" are the only caller for each delta type and
they always pass OFS/REF constant that corresponds to them, so
find_*_delta() can lose the type.  But compare_*_delta_bases()
cannot, as the other one in the objects[] array may be of different
type.

Makes sense.  Thanks.