Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 6, 2020, 17:53 UTC
Message-ID: <xmqqsg9mfk26.fsf@gitster.c.googlers.com>
In-Reply-To: <ec59a5d8-26fc-988e-4458-fd2cd421f9d5@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 12 quoted lines

>> "make distclean" can still depend on GIT-VERSION-FILE and your daily
>> cleaning needs can use "make clean" that cleans only the files that
>> can be cleaned without knowing what GIT_VERSION is, no?  That way,
>> we do not have to use dist-tars file at all, no?
>
> Hmm, so rather than dropping the last two patches, you are suggesting
> replacing this patch with a patch that moves:
>
> 	$(RM) $(GIT_TARNAME).tar.gz
> 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>
> to the 'distclean' target?

Yup.  FWIW, I consider it a feature that

    for m in maint-2.{27,28,29}
    do
	git checkout "$m" &&
        make distclean &&
	make dist || break
    do

gives me three distribution tarballs of from-scratch builds. It matters when I need to push out releases from multiple maintenance tracks at the same time (think: coordinated security releases).

I could of course move them away before running distclean in each step, but then I'd be following a different workflow from what I normally use when cutting a single release---I would rather avoid deviating from the routine when I have to be absolutely careful (again, think: coordinated security releases).

> Well, that would address your concerns, but I was hoping to fix the
> 'your current branch has to be the same as the one you created the
> tarballs on' for the '(dist)clean' target to actually remove those
> files issue.

So we on this part have directly opposing wish, unfortunately.