Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 6, 2020, 01:58 UTC
Message-ID: <xmqqa6vvgs9y.fsf@gitster.c.googlers.com>
In-Reply-To: <0cbe821b-092d-a5f9-e2ab-13a3c01e9a02@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> I did have a patch #9 that moved the removal of the tarballs from
> the 'clean' target to the 'distclean' target (that is move the new
> 'iterate over the dist-tars file' code). However, I wasn't convinced
> that it was a better place for it.

I am not either, other than "things created by 'make distX' cleaned by 'make distclean'---that sounds consistent" ;-).

> Also, just moving the new removal code would not alter the concerns
> about it that you express above. So, we need to address that either
> way.

"make distclean" can still depend on GIT-VERSION-FILE and your daily cleaning needs can use "make clean" that cleans only the files that can be cleaned without knowing what GIT_VERSION is, no? That way, we do not have to use dist-tars file at all, no?