Re: [PATCH 7/8] Makefile: don't delete dist tarballs directly by name
- From
Ramsay Jones <ramsay@ramsayjones.plus.com>
- Date
- Nov 6, 2020, 20:23 UTC
- Message-ID
- <7ad94f1a-9cc7-5ac9-2859-1d1015ea468f@ramsayjones.plus.com>
- In-Reply-To
- <xmqqsg9mfk26.fsf@gitster.c.googlers.com>
On 06/11/2020 17:53, Junio C Hamano wrote:
Show 21 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>> Hmm, so rather than dropping the last two patches, you are suggesting
>> replacing this patch with a patch that moves:
>>
>> $(RM) $(GIT_TARNAME).tar.gz
>> $(RM) $(htmldocs).tar.gz $(manpages).tar.gz
>>
>> to the 'distclean' target?
>
> Yup. FWIW, I consider it a feature that
>
> for m in maint-2.{27,28,29}
> do
> git checkout "$m" &&
> make distclean &&
> make dist || break
> do
>
> gives me three distribution tarballs of from-scratch builds. It
> matters when I need to push out releases from multiple maintenance
> tracks at the same time (think: coordinated security releases).Ah, yes. I hadn't thought about that kind of usage. Hmm, but in that case, wouldn't you rather get rid of the deletion of the tarballs in the 'clean' target completely? Then you could either remove them by hand (which I actually always do in practice anyway) at a time that suits you, or maybe add a new 'clean-tarballs' target.
(That still leaves the issue of how you would identify the tarballs in such a target, of course).
ATB, Ramsay Jones