git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] vimdiff: make layout engine more robust against user vim settings

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 8, 2022, 20:15 UTC
Message-ID
<xmqqsfnbuzrl.fsf@gitster.g>
In-Reply-To
<20220708181024.45839-1-greenfoo@u92.eu>
Fernando Ramos <greenfoo@u92.eu> writes:
> 'vim' has two configuration options ('splitbelow' and 'splitright') that
> change the way the 'split' command behaves. When they are set, the
> commands that the layout engine generates no longer work as expected.

Interesting. Does that mean that the end-user setting that was problematic with the new layout engine would have also broken the layout before your series?

> In order to fix this we can append special keyword 'letfabove' to each
Presumably "leftabove" was meant here.
Show 8 quoted lines
> 'split' and 'vertical split' subcommand found inside the command string
> generated by the layout engine.
>
> This works because whatever comes after 'leftabove' will temporally
> ignore settings 'splitbelow' and 'splitright'.
>
> Reported-by: Matthew Klein <mklein994@gmail.com>
> Signed-off-by: Fernando Ramos <greenfoo@u92.eu>
Will queue.  Thanks.
Previous: Fernando RamosNext: Fernando Ramos
Message 3 of 4 in “vimdiff: make layout engine more robust against user vim settings”
  1. vimdiff: make layout engine more robust against user vim settingsFernando Ramos, Jul 8, 2022
  2. Fernando RamosJul 8, 2022
  3. Junio C HamanoJul 8, 2022
  4. Fernando RamosJul 8, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.