git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] vimdiff: make layout engine more robust against user vim settings

From
Fernando Ramos <greenfoo@u92.eu>
Date
Jul 8, 2022, 22:37 UTC
Message-ID
<YsixuwhSwTCapW5L@zacax395.localdomain>
In-Reply-To
<xmqqsfnbuzrl.fsf@gitster.g>
On 22/07/08 01:15PM, Junio C Hamano wrote:
>
> Interesting.  Does that mean that the end-user setting that was
> problematic with the new layout engine would have also broken the
> layout before your series?

Surprisingly enough, no. Turns out the commands used before the new layout engine was introduced did *not* use 'split' nor 'vertical split' (which are the commands affected by those two global settings).

Instead, it relayed on the fact that 'vim -d' always opens splits vertically and then readjusted window positions with 'wincmd [HJKL]'.

The old way was limited in the amount of things that could be achieved and that's why it was changed... but I completely missed those two global settings capable of changing the behaviour of the new commands.

> > In order to fix this we can append special keyword 'letfabove' to each
> 
> Presumably "leftabove" was meant here.
You are right. Sorry.
> Will queue.  Thanks.
Thank you!
Previous: Junio C Hamano
Message 4 of 4 in “vimdiff: make layout engine more robust against user vim settings”
  1. vimdiff: make layout engine more robust against user vim settingsFernando Ramos, Jul 8, 2022
  2. Fernando RamosJul 8, 2022
  3. Junio C HamanoJul 8, 2022
  4. Fernando RamosJul 8, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.