From: Junio C Hamano Date: Fri, 08 Jul 2022 20:15:42 GMT Subject: Re: [PATCH] vimdiff: make layout engine more robust against user vim settings Message-ID: In-Reply-To: <20220708181024.45839-1-greenfoo@u92.eu> Fernando Ramos writes: > 'vim' has two configuration options ('splitbelow' and 'splitright') that > change the way the 'split' command behaves. When they are set, the > commands that the layout engine generates no longer work as expected. Interesting. Does that mean that the end-user setting that was problematic with the new layout engine would have also broken the layout before your series? > In order to fix this we can append special keyword 'letfabove' to each Presumably "leftabove" was meant here. > 'split' and 'vertical split' subcommand found inside the command string > generated by the layout engine. > > This works because whatever comes after 'leftabove' will temporally > ignore settings 'splitbelow' and 'splitright'. > > Reported-by: Matthew Klein > Signed-off-by: Fernando Ramos Will queue. Thanks.