Re: [PATCH 4/4] doc add: renormalize is not idempotent for CRCRLF

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2022, 22:04 UTC
Message-ID: <xmqqsfn8pqts.fsf@gitster.g>
In-Reply-To: <e45c4fc1-3a30-726c-51f3-00caeca0a552@iee.email>

Philip Oakley <philipoakley@iee.email> writes:

Show 7 quoted lines

>>> +	This option implies `-u`. Lone CR characters are untouched, so
>>> +	cleaning *^* not idempotent. A CRCRLF sequence cleans to CRLF.
>> Lack of verb BE somewhere. 
> '^' It took me three re-reads to see my mistyping as my head knew what
> I'd meant to write, I've marked above as a note to self.
> Aside: Are there any guides / suggestions / how-to's for on-line
> reviewing that you can recommend o

Sorry, but I do not know of any good "trick" to fight against our common tendency to easily miss trivial typoes and thinkos in what we ourselves wrote. We can be surprisingly blind to what a colleague can spot immediately, and that is why it helps to have a thorough read-through by a reviewer with fresh eyes. When I was a more prolific contributor, I sometimes tried to read aloud what I wrote to myself, both docs and code, and caught silly mistakes before sending them out to the list, but I do not recommend it to others.