git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] abspath.h file is generated by makeheaders tool

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 16, 2022, 16:51 UTC
Message-ID
<xmqqsfjn4spf.fsf@gitster.g>
In-Reply-To
<Y0wDieA32uVtYmgx@danh.dev>
Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:
Show 6 quoted lines
> This will break cross-compilation.
> At the very least, we needs to use either HOSTCC (likes linux project),
> HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile
> makeheaders
>
> So, something like (not tested, whatsoever):

I find it a bit irresponsible to leave the suggestion sounding as if this is a good idea as long as it does not break cross-compilation, which will (mis)lead the original poster to waste even more time on this topic (and waste others' time on responding to it), so let me repeat what I already said a few times.

Whether the headers mechanically generated gets committed or not, this line of change is unwelcome. Developers should be able to look at the header files (and interface document, if we ever generate one out of structured comments in the header files) when using common functions that they are not (yet) familiar with, and we want to see our header files manually curated.

Thanks.
Previous: Skrab SahNext: Đoàn Trần Công Danh
Message 7 of 11 in “abspath.h file is generated by makeheaders tool”
  1. abspath.h file is generated by makeheaders toolskrab-sah via GitGitGadget, Oct 12, 2022
  2. Ævar Arnfjörð BjarmasonOct 12, 2022
  3. abspath.h file is generated by makeheaders toolskrab-sah via GitGitGadget, Oct 13, 2022
  4. Skrab SahOct 16, 2022
  5. Đoàn Trần Công DanhOct 16, 2022
  6. Skrab SahOct 16, 2022
  7. Junio C HamanoOct 16, 2022
  8. Đoàn Trần Công DanhOct 17, 2022
  9. Skrab SahOct 17, 2022
  10. Junio C HamanoOct 17, 2022
  11. Skrab SahOct 18, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.