Re: [PATCH v2] abspath.h file is generated by makeheaders tool

From: Skrab Sah <skrab.sah@gmail.com>
Date: Oct 16, 2022, 16:06 UTC
Message-ID: <CA+J78MUsYXDzc7wf0S4J7WimFFpL-zEo5gftT17syT46CnMaqA@mail.gmail.com>
In-Reply-To: <Y0wDieA32uVtYmgx@danh.dev>

> This will break cross-compilation.

sorry, it was not in my mind.

Show 17 quoted lines

> At the very least, we needs to use either HOSTCC (likes linux project),
> HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile
> makeheaders
>
> So, something like (not tested, whatsoever):
>
>         CC_FOR_BUILD = $(CC)
>         CFLAGS_FOR_BUILD = $(CFLAGS)
>         LDFLAGS_FOR_BUILD = $(LDFLAGS)
>         QUIET_HOSTCC = echo '   ' HOSTCC $@;
>         QUIET_MAKEHEADERS = echo '      ' MAKEHEADERS $@;
>
>         makeheaders: tools/makeheaders.c
>                 $(QUIET_HOSTCC)$(CC_FOR_BUILD) -o $@ $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) $<
>
>         abspath.h: abspath.c makeheaders
>                 $(QUIET_MAKEHEADERS)./makeheaders $<

Ok, as you suggested above, I will modify the patch according to it.

If anyone suggests it will be good or not, I have another way to do it. What if we put the makeheaders tool executable in an online platform and then put it in Makefile to download it over the internet according to the system.